Update outbox macro #5970
Merged
Update outbox macro #5970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escattone
requested changes
Apr 22, 2024
Comment on lines
58
to
62
| {% set comma = joiner(', ') %} | ||
| {% for user in message.to.all() -%} | ||
| {{ comma() }} | ||
| {{ name_link(user) }} | ||
| {%- endfor %} |
There was a problem hiding this comment.
This is a nice change, but now the inner loop should be removed and the set comma ... moved outside the loop.
There was a problem hiding this comment.
Good catch. Thanks. I saw another piece that needed updated as well thanks to this!
escattone
requested changes
Apr 22, 2024
| @@ -52,27 +52,27 @@ | |||
|
|
|||
| {% macro outbox_message(message) -%} | |||
| <span class="to"> | |||
| {% if message.recipient %} | |||
| {% if message.to %} | |||
There was a problem hiding this comment.
I don't know, but I'm wondering if it would be better to use if message.recipients_count > 0 here?
Comment on lines
58
to
63
| {% for user in message.to.all() -%} | ||
| {{ comma() }} | ||
| {{ name_link(user) }} | ||
| {%- endfor %} | ||
| {% else %} | ||
| {{ name_link(message.recipient) }} | ||
| {% endif %} | ||
| {% endfor %} |
There was a problem hiding this comment.
Outdent all of these lines -- the for...else...endfor to match the line with the {% set comma = joiner(', ') %}.
There was a problem hiding this comment.
I did as requested - I need to find some rules/a linter for Jinja files.....
escattone
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.